Skip to content

Insert a space after the colon in Ruff suppression comments - #27123

Merged
MichaReiser merged 1 commit into
mainfrom
micha/ruff-add-ignore-spacing
Jul 23, 2026
Merged

Insert a space after the colon in Ruff suppression comments#27123
MichaReiser merged 1 commit into
mainfrom
micha/ruff-add-ignore-spacing

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Insert a space after the colon in ruff: ignore and ruff: file-ignore colon, following the precedence of most Python tooling.

Fixes #27114.

Test Plan

Testing: Updated the affected snapshots and ran the focused linter, CLI, Markdown, and server tests.

@astral-sh-bot

astral-sh-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+18730 -18730 violations, +0 -0 fixes in 28 projects; 28 projects unchanged)

DisnakeDev/disnake (+64 -64 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ disnake/app_commands.py:509:33: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- disnake/app_commands.py:509:33: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ disnake/asset.py:108:40: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- disnake/asset.py:108:40: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ disnake/components.py:131:97: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- disnake/components.py:131:97: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ disnake/components.py:169:102: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- disnake/components.py:169:102: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ disnake/entitlement.py:157:63: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- disnake/entitlement.py:157:63: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 118 additional changes omitted for project

RasaHQ/rasa (+73 -73 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ .github/tests/test_download_pretrained.py:102:19: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/tests/test_download_pretrained.py:102:19: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/tests/test_download_pretrained.py:26:19: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/tests/test_download_pretrained.py:26:19: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/tests/test_download_pretrained.py:46:19: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/tests/test_download_pretrained.py:46:19: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/tests/test_download_pretrained.py:63:19: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/tests/test_download_pretrained.py:63:19: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/tests/test_download_pretrained.py:83:19: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/tests/test_download_pretrained.py:83:19: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 136 additional changes omitted for project

apache/airflow (+773 -773 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ airflow-core/src/airflow/api_fastapi/execution_api/deps.py:19:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff: file-ignore`
- airflow-core/src/airflow/api_fastapi/execution_api/deps.py:19:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff:file-ignore`
+ airflow-core/src/airflow/api_fastapi/execution_api/security.py:68:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff: file-ignore`
- airflow-core/src/airflow/api_fastapi/execution_api/security.py:68:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff:file-ignore`
+ airflow-core/src/airflow/callbacks/callback_requests.py:29:88: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- airflow-core/src/airflow/callbacks/callback_requests.py:29:88: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ airflow-core/src/airflow/cli/commands/api_server_command.py:152:30: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- airflow-core/src/airflow/cli/commands/api_server_command.py:152:30: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ airflow-core/src/airflow/dag_processing/bundles/manager.py:31:64: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- airflow-core/src/airflow/dag_processing/bundles/manager.py:31:64: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 1536 additional changes omitted for project

apache/superset (+3023 -3023 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ RELEASING/changelog.py:274:59: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- RELEASING/changelog.py:274:59: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ RELEASING/changelog.py:281:53: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- RELEASING/changelog.py:281:53: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ RELEASING/changelog.py:292:82: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- RELEASING/changelog.py:292:82: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ RELEASING/generate_email.py:34:111: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- RELEASING/generate_email.py:34:111: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ RELEASING/verify_release.py:144:35: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- RELEASING/verify_release.py:144:35: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 6036 additional changes omitted for project

bokeh/bokeh (+20 -20 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ examples/basic/data/color_mappers.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- examples/basic/data/color_mappers.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ examples/interaction/js_callbacks/color_sliders.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- examples/interaction/js_callbacks/color_sliders.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ examples/models/buttons.py:15:5: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- examples/models/buttons.py:15:5: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ examples/models/calendars.py:14:5: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- examples/models/calendars.py:14:5: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ examples/models/sliders.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- examples/models/sliders.py:9:5: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 30 additional changes omitted for project

ibis-project/ibis (+320 -320 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ .github/workflows/algolia/configure-algolia-api.py:1:37: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/workflows/algolia/configure-algolia-api.py:1:37: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/workflows/algolia/upload-algolia-api.py:164:54: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/workflows/algolia/upload-algolia-api.py:164:54: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/workflows/algolia/upload-algolia-api.py:178:56: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/workflows/algolia/upload-algolia-api.py:178:56: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/workflows/algolia/upload-algolia-api.py:190:66: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/workflows/algolia/upload-algolia-api.py:190:66: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ .github/workflows/algolia/upload-algolia-api.py:1:37: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- .github/workflows/algolia/upload-algolia-api.py:1:37: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 630 additional changes omitted for project

langchain-ai/langchain (+1105 -1105 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ libs/core/langchain_core/_api/deprecation.py:296:74: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- libs/core/langchain_core/_api/deprecation.py:296:74: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ libs/core/langchain_core/callbacks/base.py:1082:14: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- libs/core/langchain_core/callbacks/base.py:1082:14: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ libs/core/langchain_core/callbacks/base.py:1114:32: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- libs/core/langchain_core/callbacks/base.py:1114:32: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ libs/core/langchain_core/callbacks/base.py:1141:32: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- libs/core/langchain_core/callbacks/base.py:1141:32: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ libs/core/langchain_core/callbacks/base.py:1157:32: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- libs/core/langchain_core/callbacks/base.py:1157:32: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 2200 additional changes omitted for project

latchbio/latch (+12 -12 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ src/latch/resources/launch_plan.py:53:15: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- src/latch/resources/launch_plan.py:53:15: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ src/latch_cli/constants.py:8:17: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- src/latch_cli/constants.py:8:17: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ src/latch_cli/main.py:1:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff: file-ignore`
- src/latch_cli/main.py:1:1: noqa-comments [*] `ruff: noqa` comment used instead of `ruff:file-ignore`
+ src/latch_cli/main.py:21:67: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- src/latch_cli/main.py:21:67: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
+ src/latch_cli/services/docker/utils.py:116:54: noqa-comments [*] `noqa` comment used instead of `ruff: ignore`
- src/latch_cli/services/docker/utils.py:116:54: noqa-comments [*] `noqa` comment used instead of `ruff:ignore`
... 14 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
noqa-comments 37460 18730 18730 0 0

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Jul 23, 2026
@MichaReiser
MichaReiser requested a review from ntBre July 23, 2026 11:31
@MichaReiser
MichaReiser marked this pull request as ready for review July 23, 2026 11:31
ntBre
ntBre approved these changes Jul 23, 2026
View reviewed changes

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichaReiser
MichaReiser merged commit d96eab0 into main Jul 23, 2026
47 checks passed
@MichaReiser
MichaReiser deleted the micha/ruff-add-ignore-spacing branch July 23, 2026 12:22
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2026
Merged
@scottames-github-bot scottames-github-bot Bot mentioned this pull request Jul 28, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zsol zsol zsol approved these changes
@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent spacing in new # ruff:{ignore,file-ignore,disable,enable} comments

3 participants

@MichaReiser @zsol @ntBre