Null values now pass in "notInstance" checks - #4412
Open
kqarryzada wants to merge 1 commit into
Open
kqarryzada wants to merge 1 commit into
kqarryzada wants to merge 1 commit into
Conversation
kqarryzada
commented
Sep 21, 2026
| .withMessage(actualIsNull()); | ||
| void should_throw_error_if_type_is_null() { | ||
| assertThatNullPointerException().isThrownBy(() -> objects.assertIsNotExactlyInstanceOf(someInfo(), "Yoda", null)) | ||
| .withMessage("The given type should not be null"); |
Author
There was a problem hiding this comment.
The diff looks strange for these because I left "should_pass" tests above the "should_throw" ones, but I didn't modify any "should_throw" tests.
Updated the implementation of methods such as Objects.isNotInstanceOf() to pass when the 'actual' value is null. This is intended to align with the way Java treats the 'instanceof' keyword.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the implementation of methods such as Objects.isNotInstanceOf() to pass when the 'actual' value is null. This is intended to align with the way Java treats the 'instanceof' keyword.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.