Conversation
Member
|
Hi @mipo256, thanks for the PR! As far as I can see, you're trying to address what has been asked at #1652. However, we have already started working in this direction: see #2519 and In lights of that, I'm closing the PR as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the ability to control the execution of the code block in a more general manner. For now,
assertThatCodecreatesAbstractTrhowableAssert, which only checks the error thrown by the code block. But sometimes, asserting that the code block did not throw anything and resulted in the particular value is very useful. Example: