Skip to content

Map additional assertions - #2681

Open
groov1kk wants to merge 1 commit into
assertj:3.xfrom
groov1kk:add-map-assert-validations
Open

Map additional assertions#2681
groov1kk wants to merge 1 commit into
assertj:3.xfrom
groov1kk:add-map-assert-validations

Conversation

@groov1kk

@groov1kk groov1kk commented Jun 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

  1. Added the following methods for the MapAssert:

    • containsKeys(Iterable)
    • containsValues(Iterable)
    • containsOnlyValues(Object[])
    • containsOnlyValues(Iterable)
    • doesNotContainKeys(Iterable)
    • doesNotContainValues(Object[])
    • doesNotContainValues(Iterable)

  2. Fixed the issue containsKey in AbstractMapAssert overuses containsKeys implementation #2428

@groov1kk groov1kk changed the title add map assert additional methods MapAssert additional methods Jun 23, 2022
@groov1kk
groov1kk force-pushed the add-map-assert-validations branch 3 times, most recently from a69cff6 to 45f9603 Compare July 3, 2022 08:44
@groov1kk
groov1kk force-pushed the add-map-assert-validations branch from 6d255d1 to 769d5d0 Compare August 5, 2022 11:16
@groov1kk groov1kk changed the title MapAssert additional methods MapAssert additional assertions Aug 5, 2022
@groov1kk groov1kk changed the title MapAssert additional assertions Map additional assertions Aug 6, 2022
@groov1kk
groov1kk force-pushed the add-map-assert-validations branch 2 times, most recently from 7bfc9c0 to c965199 Compare August 10, 2022 09:37
@scordio

scordio commented Aug 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Hopefully, 661e5d5 fixes the issue with pitest.

BTW, thanks for your patience, @groov1kk! We will review your PR as soon as we can.

@scordio scordio added this to the 3.24.0 milestone Aug 10, 2022
@scordio

scordio commented Aug 10, 2022

Copy link
Copy Markdown
Member

To be checked how this PR overlaps with #2433.

@groov1kk

groov1kk commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

To be checked how this PR overlaps with #2433.

I saw this PR. There were created two additional methods containsKeyForProxy and doesNotContainKey with the single parameter. We don't need additional methods when we are not going to invoke them inside a method with generic vararargs.
As that PR requires additional work, I decided to fix this issue together with my changes.

@scordio scordio modified the milestones: 3.24.0, 3.25.0 Dec 26, 2022
@groov1kk
groov1kk force-pushed the add-map-assert-validations branch from 0febf98 to a48d63a Compare March 22, 2023 18:31
@groov1kk
groov1kk force-pushed the add-map-assert-validations branch from a48d63a to 310dd5c Compare March 23, 2023 20:22
@scordio
scordio force-pushed the main branch 2 times, most recently from 38c7b4b to 3cde5bf Compare July 20, 2023 15:20
@scordio scordio modified the milestones: 3.25.0, 3.26.0 Dec 17, 2023
@scordio scordio modified the milestones: 3.26.0, 3.27.0 Apr 9, 2024
@scordio
scordio force-pushed the 3.x branch 2 times, most recently from 301ca01 to c730d18 Compare June 1, 2024 16:04
@scordio scordio removed this from the 3.27.0 milestone Nov 25, 2024
@scordio scordio added this to the 3.28.0 milestone Nov 25, 2024
@scordio scordio modified the milestones: 3.28.0, 4.0.0-M1 Jan 3, 2025
@scordio scordio modified the milestones: 4.0.0-M1, 4.0.0-M2 Jan 31, 2025
@joel-costigliola joel-costigliola modified the milestones: 4.0.0-M2, 4.x Jul 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.x

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@groov1kk @scordio @joel-costigliola