Skip to content

[CI fix] Allow add-label to fail in binary-compatibility.yml - #2667

Merged
joel-costigliola merged 1 commit into
assertj:mainfrom
ascopes:patch-2
Jun 19, 2022
Merged

joel-costigliola merged 1 commit into
assertj:mainfrom
ascopes:patch-2

Conversation

@ascopes

@ascopes ascopes commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

Binary-compatibility is currently failing when attempting to add a label to
the resource behind this integration when the person running the CI does not have
permission to manipulate that resource.

This allows that error to be ignored.

Binary-compatibility is currently failing when attempting to add a label to 
the resource behind this integration when the person running the CI does not have
permission to manipulate that resource.

This allows that error to be ignored.
@joel-costigliola
joel-costigliola merged commit b115a14 into assertj:main Jun 19, 2022
@joel-costigliola

Copy link
Copy Markdown
Member

Integrated thanks @ascopes!

@scordio

scordio commented Jun 19, 2022

Copy link
Copy Markdown
Member

@ascopes under which PR did you get the failure? I'm wondering if it's related to the default token permissions and if it's something we could fix.

If this doesn't work with PR raised from fork branches, it kills a bit the purpose of this label.

@ascopes

ascopes commented Jun 19, 2022 •

Copy link
Copy Markdown
Contributor Author

@scordio it is under #2650 on the most recent build

@ascopes
ascopes deleted the patch-2 branch June 19, 2022 07:41
@scordio

scordio commented Jun 19, 2022

Copy link
Copy Markdown
Member

Thanks, will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants