Skip to content

Remove Byte Buddy shading - #2477

Merged
scordio merged 1 commit into
mainfrom
remove_byte-buddy_shading
Feb 12, 2022
Merged

scordio merged 1 commit into
mainfrom
remove_byte-buddy_shading

Conversation

@scordio

@scordio scordio commented Jan 29, 2022

Copy link
Copy Markdown
Member

Fixes #2470.

@scordio

scordio commented Jan 29, 2022

Copy link
Copy Markdown
Member Author

@bjhargrave @kriegfrj would you mind having a look at this PR?

Removing the shading of byte buddy impacted the Maven configuration for OSGi. I inspected the generated manifest and it looks good to me but would be great to have a check from you as well.

@bjhargrave

Copy link
Copy Markdown
Contributor

I am out of the office until Feb 3. I can look then.

@scordio

scordio commented Jan 29, 2022

Copy link
Copy Markdown
Member Author

Sure and thanks, @bjhargrave.

Comment thread pom.xml
@scordio
scordio force-pushed the remove_byte-buddy_shading branch from 463004b to c1e829d Compare January 30, 2022 09:16
@scordio

scordio commented Feb 12, 2022

Copy link
Copy Markdown
Member Author

I verified these changes once more and I couldn't find anything wrong with them, so I go ahead with the merge.

@bjhargrave in case you have time to look at them and you spot something wrong, do let us know, please.

@scordio
scordio merged commit c61eb47 into main Feb 12, 2022
@scordio
scordio deleted the remove_byte-buddy_shading branch February 12, 2022 10:26
@bjhargrave

Copy link
Copy Markdown
Contributor

This looks good to me.

We will soon release Bnd 6.2 which has a new packaging mode for bnd-maven-plugin which covers the jar packaging as well. So we will propose a PR to move to that once Bnd 6.2 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not shade Byte Buddy

3 participants