Skip to content

Preliminary code to ensure AbstractMapAssert uses correct containsKey… - #2433

Open
clouded-minds wants to merge 9 commits into
assertj:3.xfrom
clouded-minds:refactor-abstract-map-assert
Open

clouded-minds wants to merge 9 commits into
assertj:3.xfrom
clouded-minds:refactor-abstract-map-assert

Conversation

@clouded-minds

@clouded-minds clouded-minds commented Dec 10, 2021 •

Copy link
Copy Markdown

… implementation

Check List:

Following the contributing guidelines will make it easier for us to review and accept your PR.

@scordio scordio added this to the 3.24.0 milestone Aug 10, 2022
@scordio scordio modified the milestones: 3.24.0, 3.25.0 Dec 26, 2022
@scordio
scordio force-pushed the main branch 2 times, most recently from 38c7b4b to 3cde5bf Compare July 20, 2023 15:21
@scordio scordio modified the milestones: 3.25.0, 3.26.0 Dec 17, 2023
@scordio scordio added the status: not ready A change that requires additional work label May 20, 2024
@scordio scordio modified the milestones: 3.26.0, 3.27.0 May 20, 2024
@scordio
scordio force-pushed the 3.x branch 2 times, most recently from 301ca01 to c730d18 Compare June 1, 2024 16:04
@scordio scordio modified the milestones: 3.27.0, 3.28.0 Nov 25, 2024
@scordio scordio modified the milestones: 3.28.0, 4.0.0-M1 Jan 3, 2025
@scordio scordio modified the milestones: 4.0.0-M1, 4.0.0-M2 Jan 31, 2025
@joel-costigliola

Copy link
Copy Markdown
Member

very late review sorry:

  • all PMD related addition should be removed
  • rebase or backport to main branch

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: not ready A change that requires additional work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

containsKey in AbstractMapAssert overuses containsKeys implementation

3 participants