Map entry values handle deep equality comparison again - #2265
Merged
Merged
Conversation
This appears to have broken in PR assertj#2167 specifically with the use of `Map.remove(Object, Object)` that does not perform deep equality checking on the map entry value (e.g. arrays).
schlosna
added a commit
to palantir/atlasdb
that referenced
this pull request
Jun 17, 2021
AssertJ 3.20.0 has a regression with
MapAssert.containsExactlyInAnyOrderEntriesOf where Map values are not
compared with deep-equality on values (e.g. byte arrays).
assertj/assertj#2264
assertj/assertj#2265
Member
|
@schlosna thank you so much for the PR. I moved the test closer to the internal implementation and added some minor changes. |
Contributor
Author
|
Excellent, thanks for the quick review and merge @scordio ! Do you have an idea when you might cut the next release? Thanks! |
Member
|
We would like to address #2173 (comment) and then we will deliver 3.20.2. |
neo-technology-build-agent
pushed a commit
to neo4j/graph-data-science
that referenced
this pull request
Jul 15, 2021
This is to get the fix of assertj/assertj#2265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have broken in PR #2167 specifically with the use of
Map.remove(Object, Object)that does not perform deep equalitychecking on the map entry value (e.g. arrays).
Check List:
AbstractMapAssert#containsExactlyInAnyOrderEntriesOf#2264Following the contributing guidelines will make it easier for us to review and accept your PR.