This repository was archived by the owner on Nov 29, 2019. It is now read-only.
Tech upgrade social auth#814
Open
gary-bluenove wants to merge 15 commits into
Open
Conversation
gary-bluenove
commented
Oct 22, 2019
gary-bluenove
commented
Contributor
- Add the instagram icon for social media
- Update the social-auth package for Linked (moved to OAUTH2)
ayyazdaniaryan
approved these changes
Nov 25, 2019
ayyazdaniaryan
left a comment
ayyazdaniaryan
left a comment
Contributor
There was a problem hiding this comment.
Looks okay. The bump from 2.0.0 -> 3.2.0 Doesn't exactly touch anything that we use majorly. The only point is to fully test Google login, as they moved away from G+ api to the new google-oauth2 way. Beyond that, nothing in SAML, nor OAuth are touched. Should be a smooth sailing upgrade for V2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.