This repository was archived by the owner on Nov 29, 2019. It is now read-only.
update urllib3 dependency#794
Open
tdesvenain wants to merge 1 commit into
Open
Conversation
tdesvenain
force-pushed
the
update-dependencies-DEVAS-1999
branch
from
4f6a680 to
28e54bc
Compare
ayyazdaniaryan
approved these changes
Sep 30, 2019
ayyazdaniaryan
left a comment
ayyazdaniaryan
left a comment
Contributor
There was a problem hiding this comment.
Should be a fine upgrade. But, perhaps you can double check if 1.25.6 doesn't break any of the other dependencies? Just food for thought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.