Skip to content
This repository was archived by the owner on Nov 29, 2019. It is now read-only.

redux refacto#785

Open
pascalhuynh wants to merge 2 commits into
developfrom
DEVAS-2211-refacto-redux
Open

redux refacto#785
pascalhuynh wants to merge 2 commits into
developfrom
DEVAS-2211-refacto-redux

Conversation

@pascalhuynh

Copy link
Copy Markdown
Contributor

Enclosed my current audit of Redux in the project 201808_Bluenove_Redux-coverage.xlsx

There are things that need to be done on this branch:

  • create missing unit tests
  • remove unneeded types
  • replace hardcoded action types
  • watch out for inputs that are not consistent for reducers (e.g a boolean is expected but we use a string as a parameter, an array is expected but we use and object) THAT MEANS IN ASSEMBL you have inconsistent call on the action that call the reducer
  • use a consistent test template (e.g check theme actions, reducers source and unit test files)
  • above all redux should return and update a STATE not single variable like its use in many place in ASSEMBL

@tdesvenain tdesvenain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
writing the best practices in a .md file would be great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants