This repository was archived by the owner on Nov 29, 2019. It is now read-only.
Invoke setup ctx#705
Open
MathieuVDP wants to merge 18 commits into
Open
Conversation
MathieuVDP
requested review from
ayyazdaniaryan,
mohamedzayed92 and
vincentfretin
ayyazdaniaryan
force-pushed
the
invoke
branch
3 times, most recently
from
f00719b to
437d05e
Compare
pascalhuynh
force-pushed
the
invoke
branch
2 times, most recently
from
d7ecd93 to
ecf815f
Compare
pascalhuynh
force-pushed
the
invoke
branch
2 times, most recently
from
5b25d2e to
0c78561
Compare
Contributor
|
This PR is poorly merged/rebased. Could you rebase this with the latest of |
MathieuVDP
force-pushed
the
invoke_setup_ctx
branch
from
551e9a8 to
14a8634
Compare
gary-bluenove
approved these changes
Jun 20, 2019
gary-bluenove
left a comment
gary-bluenove
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I think Aryan is better placed to spot anything odd here or Cedric who has worked on this recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T KNOW IF IT BREAKS ANYTHING, PLEASE REVIEW
Fix the issue with updating account_data.yaml in AWS and not getting the right configuration with invoke. The issue came from the fact that setup_ctx doesn't update the configuration if a file changed between the start of the invoke process and the actual actions. I needed to make "invoke.yaml" the target to ensure correct inheritance after the first call to setup_ctx.