This repository was archived by the owner on Nov 29, 2019. It is now read-only.
Review timeline ordering structures#636
Open
maparent wants to merge 2 commits into
Open
Conversation
…ird side effects. Use cascade=expunge instead.
maparent
force-pushed
the
repair_timeline_order
branch
from
d547d9c to
9f21be5
Compare
Contributor
|
We don't use the old interface and don't use the linked chain. We currently use the new interface with the order field. We should remove the previous_event field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linked list structure (previous_event) was a bit fragile in reordering operations; I had fixed that with post_updates earlier, but it required acrobatics around deletes. Not healthy. I repaired with a cascade option, which seems to work reliably.
I noted while there that there's a new field order, which is not kept in sync with the linked list. Why? Were you aware of the linked list field?
I also noted that creating a new timeline item with the old interface fails because the JS wants to send an int in the json, which the float field refuses. That's a separate fix, which may have wide-ranging consequences. I could also be more precise here.