Updated all template project.json tools to use 1.1#572
Updated all template project.json tools to use 1.1#572Gimly wants to merge 2 commits intoaspnet:devfrom
Conversation
There were still tools dependencies in the project.json file that were depending on .Net Core 1.0. This means that on a machine with only .Net Core 1.1 installed (like the microsoft/aspnetcore-build docker image) the `dotnet publish-iis` command would fail because it was trying to find .Net Core 1.0. Using the latest 1.1.0-preview4-final versions of - Microsoft.AspNetCore.Razor.Tools - Microsoft.AspNetCore.Server.IISIntegration.Tools - Microsoft.DotNet.Watcher.Tools fixes the issue and makes the all publish work correctly on the docker machine.
|
Hi @Gimly, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@Gimly, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Hello, Is there something wrong with this pull request? Do you want me to fix something? Regards |
|
According to #684 this might be rendered redundant. AspNet peeps are probably in fire mode with VS RTM coming down the pipeline. /cc @natemcmaster |
|
@Gimly Sorry this is taking a while to merge and for not commenting so far. Thanks for this contribution. We're just working through transitioning everything in this repo to |
|
@SteveSandersonMS No problem! I was just wondering if there was something I could improve in the PR that was blocking your from merging. I completely understand that you're merging to the csproj-based tooling and that it has an impact. |
|
Again, sorry this has taken a while to get to. Now that dotnet's 1.0 As such, the changes in this PR (which would have otherwise been valuable) will not be applicable any more. So to keep things tidy, I'll close this now. Again, thanks for contributing this and for bearing with us while we make the transition to 1.0.0 tooling! |
4 participants
I figured out what was causing the issue that I had opened in #534. It was not really linked to Angular or anything as the error message could suggest, but to the publishing process.
I'm publishing my app through Bitbucket Pipelines that runs a script in a Docker image to create a CI/CD system. The script I was using was simply running
dotnet restoreand thendotnet publish. What I hadn't seen was thatdotnet publish-iisthat is called by the post publish methods was failing. It was failing because on the docker image I'm using (microsoft/aspnetcore-build) only the .Net Core 1.1 is installed. The issue was that there were still tools dependencies in the project.json file that were depending on .Net Core 1.0, and running those tools were making the publish-iis fail.Using the latest 1.1.0-preview4-final versions of
fixes the issue and makes the all publish work correctly on the docker machine.