fix: data-sources create uses text+chunk (not phantom content) + skill fact-check#159
Merged
Merged
Conversation
The inline `data-sources create` path built a request body with a `content`
field the API does not define, and omitted the required `text` and `chunk`
fields, so it always failed with a 422. Renamed the inline flag to `--text`,
send the required `chunk`, and fixed the `get`/`list` tables, which read
`content`/`last_updated` when the API returns `text`/`updated_at` (so those
columns were always blank). Added a create-body test. Verified live against
the cli-test org: inline create now succeeds and the detail view renders Text,
Chunk, and Updated At.
Also fact-checked the usage skill against docs.syllable.ai and the embedded
OpenAPI spec, professionalized the tone (removed the defect-log framing), and
corrected two skill claims:
- Variable vars. prefix: custom variables use the same bare key everywhere;
vars. is reserved for system (vars.session.*) and auto-prefixed campaign
variables. {{ vars.name }} resolves empty for a custom key named "name".
- Greeting subject: rejected with a 422 on a greeting (only valid on
email_template), confirmed live; the spec's "ignored otherwise" is wrong.
Synced AGENTS.md for the data-source flag change.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a real bug in
data-sources createand corrects the usage skill after a fact-check against docs.syllable.ai and the embedded OpenAPI spec.Data source bug (code)
createbuilt a body with acontentfield the API doesn't define and omitted the requiredtext/chunk→ it always 422'd. Now sends--text+chunk:false.get/listtables readcontent/last_updated, but the API returnstext/updated_at, so those columns were always blank. Fixed;getalso showschunk.TestDataSourcesCreateWithFlags; updated the list/get stubs to the real field names.cli-testorg: inline create now succeeds, the detail view renders Text/Chunk/Updated At, and the old--contentpath reproduced the 422.Skill (docs)
vars.variable-prefix guidance to match docs + the skill's own detailed reference: custom variables use the same bare key everywhere;vars.is only for system (vars.session.*) and auto-prefixed campaign variables.subject: rejected with a 422 on a greeting (confirmed live).Tests
gofmt,go vet,go build, and the full unit suite pass.🤖 Generated with Claude Code