Code review final batch: docs accuracy, CRUD runners, dep upgrades, usage skill (#122, #141, #142)#158
Merged
Merged
Conversation
In-binary Example fixes (now copy-pasteable): - users get/update/delete/send-email examples use an email, not a numeric id (these commands are email-keyed). - outbound: `batches requests abc-123` → `batches add-requests abc-123 --file ...` (there is no `requests` subcommand). - channels: drop the removed `delete` example, fix `targets get` to take both channel and target ids, and correct the command's Long description. Docs: - README: only `prod` is a built-in env (not staging/dev); remove the nonexistent `--api-key`/`--base-url` flag rows, document the real SYLLABLE_API_KEY/config auth and the `--yes` flag; Go 1.24+. - AGENTS.md: correct the stale "binary is checked in" line (none is), use `batches add-requests`, and drop the nonexistent `tool-definitions list`. Also carries pre-existing local doc edits (the SYLLABLE_API_KEY note in AGENTS.md and the Claude Code skill sections in README.md/CLAUDE.md). Co-Authored-By: Claude Fable 5 <[email protected]>
#141) Adds cmd/runners.go — runList / runGet / runDelete / listQuery / readJSONBody — capturing the list/get/delete/file-body boilerplate copied across ~20 resource commands. Migrates roles.go (259→188) and incidents.go (245→198) as the reference shape; behavior is unchanged (existing stub tests pass). Remaining resources can migrate incrementally. Updates the syllable-sync skill so the spec-sync automation templates new plain resources from the migrated shape, while keeping the hand-written pattern for special resources (binary output, ID fallback, custom timeouts, multipart). go test -race ./... green. Co-Authored-By: Claude Fable 5 <[email protected]>
cobra v1.8.0 → v1.10.2, viper v1.18.2 → v1.21.0 (pflag v1.0.5 → v1.0.9). Indirect dependencies drop from 20 to 13 — viper ≥1.20 no longer pulls the HCL, Java- properties, and related encoders (hashicorp/hcl and magiconair/properties are gone). go build / vet / test -race green, gofmt clean, go mod verify passes, and the binary's help/completion/flag parsing are unchanged. Co-Authored-By: Claude Fable 5 <[email protected]>
… v1.8 behavior Adds the .claude/skills/syllable-cli/ usage skill (SKILL.md + reference files) that README.md/CLAUDE.md already point to, and updates it for the code-review changes so an agent driving the CLI gets current guidance: - destructive deletes confirm interactively and require --yes non-interactively (documented in SKILL.md, commands.md, and gotchas.md — this is the change most likely to bite an agent); - channels has no delete (removed) — use `channels targets delete`; - users get/update/delete/send-email are email-keyed (corrected a stale note that said `users delete` uses a query parameter); - data-sources/services/voice-groups/roles/incidents update now take an optional positional id; inline-create integer flags now send as integers; - --output is validated, unknown --fields warn, --dry-run lists missing_required_fields, --debug redacts credentials. Sync marker bumped to v1.8.0. All documented behaviors verified against the binary. Co-Authored-By: Claude Fable 5 <[email protected]>
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final code-review batch — docs accuracy, the CRUD-runner refactor, dependency upgrades, and the usage skill. Four commits, one per concern.
go build/vet/test -racegreen,gofmtclean,go mod verifypasses.Example:strings (users email-keyed,outbound batches add-requests, channels targets/no-delete) and README/AGENTS drift (onlyprodis built-in; removed the nonexistent--api-key/--base-urlflags and documented the real auth +--yes; Go 1.24+; corrected the stale "binary is checked in" line; dropped the nonexistenttool-definitions list). Also carries the pre-existing local doc edits (SYLLABLE_API_KEY note, Claude Code skill sections).cmd/runners.go(runList/runGet/runDelete/listQuery/readJSONBody); migratedroles.go(259→188) andincidents.go(245→198) as the reference shape, behavior unchanged (stub tests pass). Thesyllable-syncskill is updated so the automation templates new plain resources from the migrated shape..claude/skills/syllable-cli/for v1.8 behavior — most importantly that destructive deletes need--yesnon-interactively (an agent driving the CLI will hit this), plus the removedchannels delete, email-keyed users, and the new flag behaviors. Every documented behavior was verified against the binary.Closes #122, #141, #142.
🤖 Generated with Claude Code