Code review batch 7: consistent update-command contract (#121)#156
Merged
Conversation
…ands (#121) data-sources, services, voice-groups, roles, and incidents `update` previously took no positional — the id had to live inside --file, an inconsistent contract vs agents/prompts/tools and still exposed to the #68 silent-wrong-resource risk. They now accept an optional positional id reconciled with the body via ensureBodyIdentifier (numeric), matching the rest of the CLI. New tests for each. (organizations `update` is the singular current-org multipart command and is intentionally unchanged.) go test -race ./... green. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121 —
data-sources,services,voice-groups,roles, andincidentsupdatepreviously took no positional (the id had to live inside--file) — an inconsistent contract vsagents/prompts/tools, and still exposed to the #68 silent-wrong-resource risk. They now accept an optional positional id reconciled with the body viaensureBodyIdentifier, matching the rest of the CLI. New test per resource.organizations updateis the singular current-org multipart command and is intentionally unchanged.Closes #121.
🤖 Generated with Claude Code