Code review batch 4: CI permissions/concurrency/-race + release guards#153
Merged
Conversation
#137 — test.yml: least-privilege permissions (contents: read), a concurrency group that cancels stale runs, push scoped to main (so a PR push no longer triggers duplicate push+PR runs), and the race detector on the unit suite. Integration is build-tag gated, so `go test -race ./...` can't touch it. #140 — add .github/CODEOWNERS so changes to the GoReleaser-generated Casks/syllable.rb (and release/CI plumbing) get a review instead of silent hand-edits; replace the release-time `go mod tidy` (which mutates go.mod/go.sum) with read-only `go mod verify`. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and release-engineering hardening — 2 issues.
test.ymlnow sets least-privilegepermissions: contents: read, adds aconcurrencygroup that cancels stale runs, scopespushtomain(eliminating the duplicate push+PR runs on feature branches), and runs the unit suite under-race. Integration is build-tag gated, sogo test -race ./...never touches it..github/CODEOWNERSso the GoReleaser-generatedCasks/syllable.rband release/CI plumbing require review rather than silent hand-edits; swap the release-timego mod tidy(mutatesgo.mod/go.sum) for read-onlygo mod verify.Closes #137, #140.
🤖 Generated with Claude Code