New BTW identification number (NL)#185
Closed
nim-odoo wants to merge 1 commit into
Closed
Conversation
Author
|
Note: this was successfully tested with a list of ~2500 existing Dutch BTW numbers and the new ones from 2020: NL001162938B28 I am checking the CI error at the moment. |
As of January 1st 2020, a new BTW identification number has been introduced in Netherlands. This commit implements the new check algorithm. The algorithm detail can be found in: http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken Closes #182
Author
|
@arthurdejong Fixes #182, tests added and CI passing. Thanks |
Owner
|
Thanks for the fix. Since the stdnum module already had a Mod 97 implementation that was used instead in a9b3e90. The test numbers were really helpful though as it helped me better confirm the correct implementation. |
nim-odoo
referenced
this pull request
in odoo/odoo
Jan 13, 2020
Steps to reproduce: - install contacts and vat number validation - setup your company country to "Netherlands" - go to contacts > add a company > try to add a dutch vat number (NL264077921B03) Previous behavior: Proper vat numbers are considered unvalid and raise a ValidationError Current behavior: Specific check added for dutch vat numbers Related: http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken https://business.gov.nl/regulation/using-checking-vat-numbers/ http://www.pruefziffernberechnung.de/U/USt-IdNr.shtml opw-2166380 closes #42681 Signed-off-by: Nicolas Martinelli (nim) <[email protected]> Co-authored-by: Nicolas Martinelli <[email protected]>
Owner
|
Hi @nim-odoo, |
Author
|
Thanks! |
nim-odoo
referenced
this pull request
in odoo/odoo
Jul 30, 2024
Steps to reproduce: - install contacts and vat number validation - setup your company country to "Netherlands" - go to contacts > add a company > try to add a dutch vat number (NL264077921B03) Previous behavior: Proper vat numbers are considered unvalid and raise a ValidationError Current behavior: Specific check added for dutch vat numbers Related: http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken https://business.gov.nl/regulation/using-checking-vat-numbers/ http://www.pruefziffernberechnung.de/U/USt-IdNr.shtml opw-2166380 closes #43081 X-original-commit: b7a8268 Signed-off-by: Nicolas Martinelli (nim) <[email protected]> Co-authored-by: Nicolas Martinelli <[email protected]>
xmo-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 30, 2024
dc673bf added this for the new 2020 identification numbers as stdnum didn't support them yet. arthurdejong/python-stdnum#185 was merged and published as part of stdnum 1.13, in master we currently require 1.17, so this code has been dead a while.
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Aug 1, 2024
dc673bf added this for the new 2020 identification numbers as stdnum didn't support them yet. arthurdejong/python-stdnum#185 was merged and published as part of stdnum 1.13, in master we currently require 1.17, so this code has been dead a while. Part-of: #175008 Signed-off-by: Wala Gauthier (gawa) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of January 1st 2020, a new BTW identification number has been
introduced in Netherlands.
This commit implements the new check algorithm.
The algorithm detail can be found in:
http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken
Note that this implementation already takes into account the following:
Even if positions 3-12 have still the format 9 digits + 'B', this might not be the case anymore in the future.
This aims to replace #183 and #184