[FIX] nl: dutch vat check broken since 01/01/2020#183
Conversation
New vat numbers received by companies after the 1st january 2020 are considered invalid.
|
@arthurdejong let me know what you think about this |
|
Can you provide of this change to the check algorithm? Where do the letters come from? Also, the tests fail due to an undefined Can you provide some sample numbers of actual companies that are valid (i.e. pass the VIES VAT validation but do not pass the check algorithm in BSN? |
CasVissers-360ERP
left a comment
There was a problem hiding this comment.
Fixes the issue for me, tested with vatnumber: NL000099998B57
vatnumber from: https://www.dezaak.nl/467/zo-ziet-btw-nummer-eruit.htm
|
Another VAT number: NL002455799B11 About the list: http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken |
@CasVissers How can this work, it contains a syntax error, causing all tests to fail? Edit: With the assumption |
|
@timmuller The PR is not correct. I'll adapt what we have done in odoo/odoo#42681 |
|
Thanks everyone for helping fix this. I've implemented the fix in a9b3e90. I will make a new release quickly. |
New vat numbers received by companies after the 1st january 2020
are considered invalid.