Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential XSS risk with
.html()on detached elementsThe $
('<i/>').html(settings.originalContent).text()pattern is not fully safe against XSS, even though the element is never appended to the DOM.<script>tags inserted via.html()/innerHTMLnever execute — that's guaranteed by the HTML5 spec, regardless of whether the element is attached to the document or not.However, event handlers like
onerroron<img>elements can still fire even on detached elements, because the browser starts attempting to load the resource (src) as soon as the element is parsed, not when it's inserted into the document. If the load fails,onerrorfires.Example payload that still executes despite never touching the live DOM:
I've replaced
html()withtext().