Implement fma and fmac for APyFloat - #669
Draft
Theodor-Lindberg wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 85.65% 85.40% -0.26%
==========================================
Files 100 100
Lines 17087 17149 +62
Branches 3081 3110 +29
==========================================
+ Hits 14636 14646 +10
- Misses 426 478 +52
Partials 2025 2025 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Theodor-Lindberg
force-pushed
the
fma
branch
2 times, most recently
from
March 26, 2025 13:52
d68a6ab to
604a2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Implement fused multiply-add (
fma) and fused multiply-accumulate (fmac) inAPyFloat. Closes #98.The plan in this PR is to implement the slow path first, as it is the easiest, and then add the fast path.
To help ensure correctness, the script for Berkeley TestFloat will be extended to include test case generation for
fma.PR Checklist