feat: SDK update for version 22.6.0#337
Conversation
ChiragAgg5k
changed the title
Greptile SummaryThis PR bumps the CLI to version 22.6.0 and introduces a new
Confidence Score: 5/5Safe to merge. The auth refactoring is well-structured and the new API key fallback paths are guarded at every console-only operation. All console-only operations (settings push/pull, default domain rule creation) are individually gated with the new capability helpers so they warn and skip gracefully when only an API key is present. The project-level auth check runs eagerly in createPushInstance/createPullInstance, preventing unauthenticated use. The scope-error soft-fail path in ensureDefaultFunctionRule/createDefaultSiteRule is correctly bounded to missing-scope exceptions and does not swallow real authorization failures. Dependency upgrades are routine patch/minor bumps. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "(build): move @appwrite.io/console pin t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -1197,6 +1306,7 @@ export class Push { | |||
| projectName?: string; | |||
There was a problem hiding this comment.
requireConsoleAuth call
requireConsoleAuth("Pushing project settings") is called here inside Push.pushSettings(), but the two entry points that reach this method already guard with the same check: the standalone pushSettings function calls it at line ~3307, and pushResources gates the call behind if (canUseConsole()). The inner call is harmless (fast-exit), but the duplication makes the intent less clear. A brief comment explaining that the inner guard is for callers who bypass the outer guards would improve readability.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/commands/push.ts
Line: 1306
Comment:
**Redundant `requireConsoleAuth` call**
`requireConsoleAuth("Pushing project settings")` is called here inside `Push.pushSettings()`, but the two entry points that reach this method already guard with the same check: the standalone `pushSettings` function calls it at line ~3307, and `pushResources` gates the call behind `if (canUseConsole())`. The inner call is harmless (fast-exit), but the duplication makes the intent less clear. A brief comment explaining that the inner guard is for callers who bypass the outer guards would improve readability.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 participants
This PR contains updates to the SDK for version 22.6.0, generated with sdk-generator 2.4.5.
Pins
@appwrite.io/consoleto the15.3.0release.What's Changed
push functionsandpullnow work with API key authentication, enabling CI usage without a console session