This repository was archived by the owner on Sep 21, 2026. It is now read-only.
Filtering - #490
Merged
Merged
Filtering#490
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
reviewed
Aug 8, 2023
Comment on lines
+112
to
+122
| <style lang="scss"> | ||
| .cool-grid { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: 2rem; | ||
|
|
||
| > :global(h2) { | ||
| grid-column: span 2; | ||
| } | ||
| } | ||
| </style> |
Contributor
Contributor
Author
There was a problem hiding this comment.
You mean the grid-template columns?
Comment on lines
+300
to
+307
| hr { | ||
| height: 1px; | ||
| width: calc(100% + 2rem); | ||
| background-color: hsl(var(--color-border)); | ||
|
|
||
| margin-block-start: 1rem; | ||
| margin-inline: -1rem; | ||
| } |
Contributor
There was a problem hiding this comment.
I think we already have dividers in pink
Contributor
Author
There was a problem hiding this comment.
Didn't find them on pink.appwrite.io 🤔
Contributor
There was a problem hiding this comment.
Then we probably need to add them 😆 but I'm sure they are in the code
| {/each} | ||
|
|
||
| <p class="u-text-center u-margin-block-start-24"> | ||
| Signed in as [email protected] <button |
Contributor
Author
There was a problem hiding this comment.
@PineappleIOnic does the firebase report return a username/email?
|
|
||
| const queries = url.searchParams.get('query'); | ||
| const parsedQueries = queryParamToMap(queries || '[]'); | ||
| console.log(parsedQueries); |
christyjacob4
suggested changes
Aug 8, 2023
christyjacob4
left a comment
christyjacob4
left a comment
Contributor
There was a problem hiding this comment.
Please address the comments
…ase]/collection-[collection]/+page.ts Co-authored-by: Christy Jacob <[email protected]>
christyjacob4
approved these changes
Aug 9, 2023
This was referenced Sep 1, 2023
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.