Skip to content

Remove relationship attributes from realtime event payloads - #8381

Merged
stnguyen90 merged 1 commit into
1.5.xfrom
improve-event-data
Jul 11, 2024
Merged

stnguyen90 merged 1 commit into
1.5.xfrom
improve-event-data

Conversation

@byawitz

@byawitz byawitz commented Jul 11, 2024 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Mark all relationship attributes as sensitive so they aren't passed via realtime to prevent sending data to subscribers who shouldn't have access to the nested data.

Test Plan

Manually

Related PRs and Issues

None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@byawitz
byawitz requested review from eldadfux and stnguyen90 July 11, 2024 15:03

@stnguyen90 stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified no relationships are included in realtime event payload for create, update, and delete:

image

@stnguyen90 stnguyen90 changed the title improve: events data Remove relationship attributes from realtime event payloads Jul 11, 2024
@stnguyen90
stnguyen90 merged commit d98e04c into 1.5.x Jul 11, 2024
@stnguyen90
stnguyen90 deleted the improve-event-data branch July 11, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants