Skip to content

Fix: Don't Override robots.txt for Other Domains - #8185

Merged
christyjacob4 merged 2 commits into
appwrite:1.5.xfrom
ItzNotABug:fix-robots-txt
May 24, 2024
Merged

christyjacob4 merged 2 commits into
appwrite:1.5.xfrom
ItzNotABug:fix-robots-txt

Conversation

@ItzNotABug

@ItzNotABug ItzNotABug commented May 23, 2024 •

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR allows using custom robots.txt on function domains.

Test Plan

Manual -

Robots.txt

Screenshot 2024-05-23 at 2 58 16 PM Screenshot 2024-05-23 at 2 58 22 PM

Humans.txt

Screenshot 2024-05-23 at 3 57 24 PM Screenshot 2024-05-23 at 3 57 29 PM

Related PRs and Issues

N/A

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@Meldiron Meldiron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 🙌
Not 100% sure about approach, let's wait for 1 more approving review before merging

@christyjacob4
christyjacob4 changed the base branch from main to 1.5.x May 24, 2024 13:15
@christyjacob4
christyjacob4 merged commit e55f0ad into appwrite:1.5.x May 24, 2024
@ItzNotABug
ItzNotABug deleted the fix-robots-txt branch May 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants