Update executor image name - #8147
Merged
Merged
Conversation
Closed
3 tasks done
christyjacob4
approved these changes
May 22, 2024
stnguyen90
previously requested changes
May 23, 2024
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
where's the update to the variables?
…e/appwrite into chore-rename-executor-image-name
christyjacob4
approved these changes
May 24, 2024
christyjacob4
dismissed
stnguyen90’s stale review
May 24, 2024 12:40
Requested changes have been made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The key name in swoole table becomes too long and generates a warning with the current image name. Replacing it with a shorter name so that key size is within bounds.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist