Skip to content

Update chunk size to 7 MB - #8060

Merged
christyjacob4 merged 3 commits into
refactor-usage-snfrom
feat-increase-chunk-size
May 2, 2024
Merged

christyjacob4 merged 3 commits into
refactor-usage-snfrom
feat-increase-chunk-size

Conversation

@vermakhushboo

@vermakhushboo vermakhushboo commented May 1, 2024 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Downloads from storage are slow. Increasing chunk size to 7 MB from 2 MB might help increase file download speed.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Comment thread app/http.php Outdated
);

$payloadSize = 6 * (1024 * 1024); // 6MB
$payloadSize = 10 * (1024 * 1024); // 10MB

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase to 11MB so that SDKs can send 10MB chunks

@vermakhushboo vermakhushboo changed the title Update chunk size to 10 MB Update chunk size to 7 MB May 2, 2024
@christyjacob4
christyjacob4 merged commit 4c7432a into refactor-usage-sn May 2, 2024
@christyjacob4
christyjacob4 deleted the feat-increase-chunk-size branch May 2, 2024 19:28
@vermakhushboo
vermakhushboo restored the feat-increase-chunk-size branch May 3, 2024 13:25
@stnguyen90
stnguyen90 deleted the feat-increase-chunk-size branch June 26, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants