feat: Maintenance container - #766
Merged
eldadfux merged 33 commits intoDec 30, 2020
Merged
Conversation
christyjacob4
commented
Dec 14, 2020
christyjacob4
commented
Dec 14, 2020
eldadfux
reviewed
Dec 14, 2020
christyjacob4
commented
Dec 14, 2020
eldadfux
requested changes
Dec 15, 2020
eldadfux
requested changes
Dec 19, 2020
eldadfux
reviewed
Dec 21, 2020
eldadfux
reviewed
Dec 21, 2020
eldadfux
reviewed
Dec 21, 2020
christyjacob4
marked this pull request as ready for review
December 22, 2020 14:07
eldadfux
reviewed
Dec 22, 2020
eldadfux
reviewed
Dec 23, 2020
eldadfux
reviewed
Dec 23, 2020
eldadfux
reviewed
Dec 25, 2020
eldadfux
reviewed
Dec 25, 2020
Member
|
@christyjacob4 LGTM. @TorstenDittmann this is a pretty big** change, can you please double check us? |
eldadfux
approved these changes
Dec 29, 2020
Contributor
Will do during the day 👍 |
Member
|
big** hehe |
TorstenDittmann
approved these changes
Dec 29, 2020
TorstenDittmann
left a comment
TorstenDittmann
left a comment
Contributor
There was a problem hiding this comment.
Only stumbled upon some minor things 🙂
lgtm 👍
Member
|
Great work @christyjacob4 👏🏻 |
eldadfux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR contains the implementation of a maintenance container which is supposed to schedule maintenance tasks across the Appwrite system
Test Plan
Will be writing e2e tests for the same.
Related PRs and Issues
https://github.com/appwrite/rfc/blob/main/001-maintenance-worker.md
Have you read the Contributing Guidelines on issues?
Yes