Add support for draft messages - #7429
Merged
Merged
Conversation
stnguyen90
force-pushed
the
feat-draft-messages
branch
from
January 18, 2024 01:20
2846f00 to
f27174e
Compare
Appwrite is using PHP 8 which doesn't support backed enums.
stnguyen90
force-pushed
the
feat-draft-messages
branch
from
January 18, 2024 01:31
f27174e to
6eeb8c4
Compare
stnguyen90
marked this pull request as ready for review
January 18, 2024 01:38
abnegate
reviewed
Jan 19, 2024
Comment on lines
+5
to
+29
| // TODO: Convert to backed enum after upgrading to PHP 8.1 | ||
| // enum MessageStatus: string | ||
| // { | ||
| // /** | ||
| // * Message that is not ready to be sent | ||
| // */ | ||
| // case Draft = 'draft'; | ||
| // /** | ||
| // * Scheduled to be sent for a later time | ||
| // */ | ||
| // case Scheduled = 'scheduled'; | ||
| // /** | ||
| // * Picked up by the worker and starting to send | ||
| // */ | ||
| // case Processing = 'processing'; | ||
| // /** | ||
| // * Sent without errors | ||
| // */ | ||
| // case Sent = 'sent'; | ||
| // /** | ||
| // * Sent with some errors | ||
| // */ | ||
| // case Failed = 'failed'; | ||
| // } | ||
|
|
Member
There was a problem hiding this comment.
Let's remove the comment and add the code back once on 8.2
abnegate
approved these changes
Jan 19, 2024
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update create and update message APIs to support draft messages.
Test Plan
Manual
Related PRs and Issues
None
Checklist