Adds uniform error logic for messaging worker and extra params for email - #7245
Merged
Merged
Conversation
abnegate
reviewed
Dec 5, 2023
stnguyen90
reviewed
Dec 12, 2023
# Conflicts: # app/controllers/api/messaging.php # composer.lock
abnegate
approved these changes
Dec 14, 2023
fanatic75
changed the title
stnguyen90
suggested changes
Dec 19, 2023
This was referenced Jan 1, 2024
2 tasks done
They should be an array of UID and not just array of Text.
2 tasks done
Messaging uniform logic fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds uniform error logic for messaging worker and extra params for email
Blocked by utopia-php/messaging#74
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist