Add chunkId to abuse key to prevent rate limit for SDKs - #7154
Merged
Merged
Conversation
eldadfux
approved these changes
Nov 16, 2023
TorstenDittmann
approved these changes
Nov 16, 2023
Contributor
|
Can we add a Test to the existing large file upload? @vermakhushboo There should be headers in the response giving us informations about the rate limits 👍🏻 |
christyjacob4
approved these changes
Nov 17, 2023
This was referenced Dec 1, 2023
2 tasks done
stnguyen90
added a commit
that referenced
this pull request
Apr 3, 2024
A previous PR added chunkId as an abuse key param to fix a problem where uploading multiple chunks of a file would trigger the `general_rate_limit_exceeded` error. For some reason, the parameter disappeared from the abuse key causing a regression. This PR adds the param back to fix the regression. Reference: * #7879 * #7154
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
chunkIdto abuse key to prevent rate limit for SDKsTest Plan
Tested manually for node SDK.
Related PRs and Issues
Checklist