Skip to content

Feat delete orphaned projects - #7015

Merged
christyjacob4 merged 8 commits into
1.4.xfrom
feat-delete-orphaned-projects
Oct 27, 2023
Merged

christyjacob4 merged 8 commits into
1.4.xfrom
feat-delete-orphaned-projects

Conversation

@shimonewman

Copy link
Copy Markdown
Contributor

No description provided.

@TorstenDittmann TorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any deletion going on 👍🏻


public function action(Group $pools, Cache $cache, Database $dbForConsole, Registry $register): void
{
//docker compose exec -t appwrite delete-orphaned-projects

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, removed

Comment on lines +92 to +93
//$dbForConsole->deleteDocument('projects', $project->getId());
//Console::success('Deleting project (' . $project->getId() . ')');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this doing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to do the actual deletion after the "dry run" is approved

@christyjacob4
christyjacob4 changed the base branch from main to 1.4.x October 27, 2023 16:20
@christyjacob4
christyjacob4 merged commit 24824e1 into 1.4.x Oct 27, 2023
@christyjacob4
christyjacob4 deleted the feat-delete-orphaned-projects branch October 27, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants