chore: cleanup obsolete CLI tasks - #6940
Merged
Merged
Conversation
shimonewman
reviewed
Oct 17, 2023
Contributor
There was a problem hiding this comment.
Does the lock file needs to be pushed?
| Console::error('[Error] Message: ' . $error->getMessage()); | ||
| Console::error('[Error] File: ' . $error->getFile()); | ||
| Console::error('[Error] Line: ' . $error->getLine()); | ||
| Console::error('[Error] Trace: ' . $error->getTraceAsString()); |
Contributor
There was a problem hiding this comment.
general question, do we want the trace on production?
Contributor
Author
There was a problem hiding this comment.
right. .removed it 👍
| <directory>./tests/e2e/Scopes</directory> | ||
| <directory>./tests/e2e/Services/Teams</directory> | ||
| <directory>./tests/e2e/Services/Realtime</directory> | ||
| <directory>./tests/e2e/Services/Webhooks</directory> |
Contributor
There was a problem hiding this comment.
iirc we moved the webhooks to the bottom like functions - because they take the longest
Contributor
Author
There was a problem hiding this comment.
Moved it to the end 👍
| */ | ||
| Console::info("Deleting builds for deployment " . $deploymentId); | ||
| $storageBuilds = $$getBuildsDevice($projectId); | ||
| $storageBuilds = $getBuildsDevice($projectId); |
Contributor
There was a problem hiding this comment.
uff, did that even work in the first place?
Contributor
Author
There was a problem hiding this comment.
Surprisingly this didn't crash the worker 😅 and only failed when we deleted a deployment
eldadfux
approved these changes
Oct 18, 2023
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist