Merge main into 1.4.x - #6930
Merged
Merged
Conversation
Some translations to spanish had some misspellings and redaction issues. Fixed that.
Fixed suggested changes by Matej
Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
Co-authored-by: Steven Nguyen <[email protected]>
…ting-guidelines Added Hacktoberfest Contributing Guidelines
hamster script fix
The realtime collection only exists in the console project so iterating over every project leads to the not found error. In addition, the deleteForProjectIds() doesn't include the console project so the realtime records were not being cleaned up properly.
This is important because when an organization is deleted, projects are fetched by the teamInternalId and if the teamInternalId is not updated when the project team is updated, the project will be deleted if the previous organization is deleted.
Since the following collections also have permissions set to the team, the team should be updated for consistency: - installations - repositories - vcsComments
Fix realtime deletes
Update teamInternalId when updating project team
Fix: spanish translations (emails)
Meldiron
approved these changes
Oct 16, 2023
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist