Refactor workers - #6928
Merged
Merged
Refactor workers#6928
Conversation
…actor-workers � Conflicts: � app/cli.php � app/console � app/controllers/api/account.php � app/controllers/api/functions.php � app/controllers/api/teams.php � app/controllers/shared/api.php � app/init.php � app/worker.php � app/workers/builds.php � app/workers/certificates.php � app/workers/deletes.php � app/workers/functions.php � app/workers/mails.php � src/Appwrite/Event/Event.php � src/Appwrite/Event/Mail.php
eldadfux
approved these changes
Oct 18, 2023
| "utopia-php/platform": "0.5.*", | ||
| "utopia-php/pools": "0.4.*", | ||
| "utopia-php/preloader": "0.2.*", | ||
| "utopia-php/queue": "0.5.*", |
Member
There was a problem hiding this comment.
We need to remove resque as a dependency. Later will be able to upgrade the PHP version.
Delegate custom deletes
chore: remove resque library and update health check endpoints
christyjacob4
approved these changes
Oct 18, 2023
stnguyen90
suggested changes
Oct 18, 2023
Comment on lines
+221
to
+222
| $workerName = $args[0]; | ||
| $workerIndex = $args[1] ?? ''; |
Contributor
There was a problem hiding this comment.
Where exactly? Because I don't see anything specified anywhere like:
appwrite/app/views/install/compose.phtml
Lines 214 to 241 in 20985c7
stnguyen90
approved these changes
Oct 18, 2023
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.