Updated error message to not user magic strings - #6487
Merged
Merged
Conversation
2 tasks
Contributor
|
@gewenyu99 is this ready for review? |
Contributor
Author
|
Yeah @stnguyen90 |
stnguyen90
suggested changes
Oct 10, 2023
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
Left some comments.
Also, it's probably best to remove the package-lock.json change from this PR to avoid conflicts.
stnguyen90
approved these changes
Oct 13, 2023
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I just merged main into here to hopefully fix the tests.
stnguyen90
suggested changes
Oct 13, 2023
Contributor
Author
|
@stnguyen90 Someone removed package log from main???? |
Contributor
Author
|
I was so confused trying to revert my changes haha |
TorstenDittmann
approved these changes
Oct 27, 2023
TorstenDittmann
left a comment
TorstenDittmann
left a comment
Contributor
There was a problem hiding this comment.
changes are fine, just curious if this works for all SDK's from the ID.unique().
christyjacob4
approved these changes
Oct 27, 2023
Contributor
Author
I think it's consistent here! |
stnguyen90
approved these changes
Oct 27, 2023
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix use of outdated magic string.
Fixes #6484
Test Plan
manual
Issues