Fix: realtime logs - #6478
Merged
Merged
Fix: realtime logs#6478
Conversation
eldadfux
approved these changes
Oct 4, 2023
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In previous patch we added
-buildsuffix to deployment containers, to separate them from execution containers. This patch was supposed to prevent executor saying that same runtime already exists (possible race condition).We forgot to rename logs container name. Realtime logs were watching logs of executor container, which didn't exit.
This PR fixes it, and realtime logs now look at proper build container.
This patch is only necessary urgent for Cloud, as the previous patch PR was not yet released in 1.4.x.
Test Plan
Before:
After:
Related PRs and Issues
Checklist