Make install confirmation case insensitive - #6097
Merged
Merged
Conversation
When a previous installation is found during installation/upgrade, the user is prompted to confirm whether they want to overwrite it. We originally only accepted 'Y', but this PR changes it to accept 'y' as well to reduce friction.
stnguyen90
force-pushed
the
feat-6094-case-insensitive-confirm
branch
from
August 31, 2023 19:25
c7facc7 to
dcc676a
Compare
stnguyen90
marked this pull request as ready for review
August 31, 2023 19:26
abnegate
approved these changes
Aug 31, 2023
This was referenced Sep 1, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a previous installation is found during installation/upgrade, the user is prompted to confirm whether they want to overwrite it. We originally only accepted 'Y', but this PR changes it to accept 'y' as well to reduce friction.
Closes #6094
Test Plan
Manual:
Related PRs and Issues
Checklist