Update migration script to not remove schedule from functions - #6095
Merged
Merged
Conversation
stnguyen90
marked this pull request as ready for review
August 31, 2023 16:01
| 'providerSilentMode', | ||
| 'logging', | ||
| 'deploymentInternalId', | ||
| 'schedule', |
Contributor
There was a problem hiding this comment.
did we make sure to include it in the collections.php file ?
Contributor
Author
There was a problem hiding this comment.
Ya, it's already in there:
appwrite/app/config/collections.php
Lines 1980 to 1990 in 458dd8c
abnegate
approved these changes
Sep 1, 2023
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
scheduleattribute was not removed from thefunctionscollection so we shouldn't delete it.Test Plan
Running migration after upgrading from 1.3.8:
functions table:
Migrating after running 1.4.0 migration:
functions table:
Related PRs and Issues
Checklist