Fix router error - #6079
Merged
Merged
Fix router error#6079
Conversation
stnguyen90
marked this pull request as ready for review
August 30, 2023 22:24
christyjacob4
approved these changes
Aug 30, 2023
abnegate
approved these changes
Aug 30, 2023
It's possible for the route to be null (no match) which leads to an error like: ``` appwrite | [Error] Timestamp: 2023-08-30T21:39:58+00:00 appwrite | [Error] Type: Error appwrite | [Error] Message: Call to a member function label() on null appwrite | [Error] File: /usr/src/code/app/controllers/general.php appwrite | [Error] Line: 50 ``` This adds a null check to prevent the error.
stnguyen90
force-pushed
the
fix-500-options-requests
branch
from
August 30, 2023 23:08
eb4f8f2 to
ac0b697
Compare
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's possible for the route to be null (no match) which leads to an error like:
This adds a null check to prevent the error.
Test Plan
Manually made an API call to a custom endpoint and confirmed no more "Call to a member function label() on null" error.
Related PRs and Issues
None
Checklist