Conversation
…sabled-mode-checks # Conflicts: # tests/e2e/Services/Databases/DatabasesConsoleClientTest.php
Merge 1.4.x into cl-1.4.x
…sabled-mode-checks
…hecks Fix collection disabled mode checks
Fix colliding ID overrides
abnegate
marked this pull request as ready for review
August 29, 2023 17:52
|
|
||
| $database = Authorization::skip(fn() => $dbForProject->getDocument('databases', $databaseId)); | ||
|
|
||
| if ($database->isEmpty() || (!$database->getAttribute('enabled') && $mode !== APP_MODE_ADMIN)) { |
Contributor
There was a problem hiding this comment.
why did we remove these checks?
Member
Author
There was a problem hiding this comment.
These routes are only accessible to API key/admin already so the checks are redundant
christyjacob4
approved these changes
Aug 29, 2023
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist