Feat SMTP Template Simplification - #6047
Merged
Merged
Conversation
eldadfux
requested changes
Aug 28, 2023
eldadfux
left a comment
eldadfux
left a comment
Member
There was a problem hiding this comment.
- Please share some screenshot of the templates look at the console now after this change.
- I think we miss a few places where we send emails, like the teams controller, please double check we haven't miss any other places.
- Not sure we need to change the syntax of how we set all the settings from emails in the controllers, we can leave as is and probably improve it in a later iteration, as it's more complex than it should be.
Contributor
Author
|
eldadfux
approved these changes
Aug 28, 2023
This was referenced Sep 1, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes HTML from the SMTP Templates, moving it into it's own template and making updating them easier
Checklist