fixed: delete attribute even if related collection does not exist - #6045

Hey @fanatic75, I have added the test case, please review 🙏

Hey @fanatic75 , any update on this?

@fanatic75 please review 🙏

Hey @stnguyen90, Could you please help to review this PR.

@abnegate please help review this PR, thanks

@stnguyen90 Can you please help with this merge it is almost 1 month and It is open 😢

Hey @Haimantika & @tessamero, could you please help merge this MR? It has been open for quite some time.

How do you get to the state where the related collection doesn't exist but the relationship does? Are there steps to reproduce?

This sounds like the bug might be related to deleting a collection itself (which should delete all of it's relationships)

Yes, I followed the steps mentioned in this issue.

👟 Reproduction steps

1. Create collection level1
2. Create collection level2
3. Create attribute in level1
   • type: relationship
   • one/two way: one way
   • key: level2
   • related collection: level2
   • relation: Many to One
   • on deleting: Cascade
4. Delete collection level2
5. Delete attribute level2 from collection level1

I agree, we should not get to this point we have a hanging attribute, but at least we should be able to fix it if it happens

I agree, we should not get to this point we have a hanging attribute, but at least we should be able to fix it if it happens

Hey @fogelito, could you please explain what I need to do further to get approvals and merge this MR? Thanks.

Hey, thanks a lot 🙏 , @abnegate can you give your review here, please?

@Akshay-Rana-Gujjar The root cause of the issue is that when a collection is deleted, the relationships are not deleted from the attributes table for the related collection, but are deleted from the metadata. So when trying to delete it manually later, it can't be found (in metadata) and gets stuck. Can we pivot the fix to address that instead?

Closing as we've updated the logic to delete the related attributes when a collection is deleted.