Added new testcase and modified duplicate domain error - #6019
Closed
mustansirgodhrawala wants to merge 3 commits into
Closed
mustansirgodhrawala wants to merge 3 commits into
mustansirgodhrawala wants to merge 3 commits into
Conversation
stnguyen90
suggested changes
Aug 19, 2023
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
Great job! I left one comment. Also, it looks like there's a lint problem somewhere.
Author
|
All recommended changes complete, we should be good to go! Thanks for the help |
Contributor
|
@mustansirgodhrawala sorry, but 1.4 made some changes to domains (replaced them with rules) so I don't think this is a problem anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses issue #4519, it performs two things.
Test Plan
I attempt to create a new project, with the same name as the one created in the previous test.
Related PRs and Issues
Checklist