Sync 1.4.x - #5961
Merged
Merged
Sync 1.4.x#5961
Conversation
Update the OAuth2 class to throw an exception if an API call to the OAuth2 provider fails and update the endpoint to redirect to the failure url with the information from the OAuth2 provider.
1. Make code optional so we can show the error via redirect 2. Capture error and error_description params from the OAuth2 provider
Previously, DSN would not be able to parse special characters like "@" or "/". This adds support by requiring the input to be url encoded and then DSN would decode it after parsing.
To handle special characters like '@' or '/', the user and secret values must be URL encoded.
Update DSN to support special chars for user and password
Co-authored-by: Christy Jacob <[email protected]>
fix: error in initialising the Exception constructor in api.php
Delete duplicate users endpoint
…-handling Improve OAuth2 error handling
Style Appwrite Error Page
Update the docs for the _APP_SMS_PROVIDER env var
test updated docker-base version
Add VCS assets
fix: abuse label for creating phone session
audio/aac mime type added
Feat appwrite assistant
Sync with master
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sync cl-1.4.x with 1.4
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist