add collections to config file and messaging scopes to config file - #5930
Merged
Merged
Conversation
fanatic75
added
the
product / messaging
fanatic75
marked this pull request as draft
August 2, 2023 15:08
fanatic75
marked this pull request as ready for review
August 3, 2023 09:39
Contributor
Author
|
@abnegate This is base out of 1.4.x branch. You can just check my ending commits for reviewing the PR. |
…t-add-messaging-collections-in-config
fanatic75
changed the title
abnegate
reviewed
Sep 8, 2023
fogelito
reviewed
Sep 10, 2023
fogelito
reviewed
Sep 10, 2023
fogelito
reviewed
Sep 10, 2023
fogelito
reviewed
Sep 10, 2023
abnegate
reviewed
Sep 12, 2023
added 2 commits
September 12, 2023 20:53
fanatic75
force-pushed
the
feat-add-messaging-collections-in-config
branch
2 times, most recently
from
September 12, 2023 15:42
ef694e4 to
54c0af2
Compare
…t-add-messaging-collections-in-config
fanatic75
force-pushed
the
feat-add-messaging-collections-in-config
branch
from
September 12, 2023 15:45
54c0af2 to
ba96f71
Compare
added 2 commits
September 12, 2023 21:19
abnegate
reviewed
Sep 12, 2023
abnegate
approved these changes
Sep 12, 2023
fogelito
reviewed
Sep 13, 2023
| return Authorization::skip(fn() => $database | ||
| ->find('targets', [ | ||
| Query::equal('userInternalId', [$document->getInternalId()]), | ||
| Query::limit(APP_LIMIT_SUBQUERY), |
Contributor
There was a problem hiding this comment.
If we added limit? do we want to order by desc to get the latest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds collections required for messaging service in config.
Test Plan
Related PRs and Issues
For more details, check out RFC
Checklist