converted desc to sentence case - #5926
Conversation
Haimantika
left a comment
Haimantika
left a comment
There was a problem hiding this comment.
Took a quick look. LGTM!
|
|
||
| App::put('/v1/account/sessions/magic-url') | ||
| ->desc('Create Magic URL session (confirmation)') | ||
| ->desc('Create magic URL session (confirmation)') |
There was a problem hiding this comment.
Not related to this PR, @Dksie09 please ignore message below.
What do y'all think about just calling this Confirm magic URL session. Like why did we use brackets?
|
|
||
| App::patch('/v1/account/sessions/:sessionId') | ||
| ->desc('Update OAuth Session (Refresh Tokens)') | ||
| ->desc('Update OAuth session (refresh tokens)') |
There was a problem hiding this comment.
@Dksie09 ignore this
Ditto this, why did we go with brackets 👀
| App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/datetime') | ||
| ->alias('/v1/database/collections/:collectionId/attributes/datetime', ['databaseId' => 'default']) | ||
| ->desc('Create DateTime Attribute') | ||
| ->desc('Create dateTime attribute') |
There was a problem hiding this comment.
| ->desc('Create dateTime attribute') | |
| ->desc('Create datetime attribute') |
|
|
||
| App::post('/v1/graphql/mutation') | ||
| ->desc('GraphQL Endpoint') | ||
| ->desc('GraphQL endpoint') |
There was a problem hiding this comment.
Yep we could add some more detail here, could be particularly useful since it ends up in SDK docblocks
There was a problem hiding this comment.
I've added a task for this. We'll address these separately to avoid scope creep.
|
|
||
| App::get('/v1/health') | ||
| ->desc('Get HTTP') | ||
| ->desc('Get http') |
There was a problem hiding this comment.
| ->desc('Get http') | |
| ->desc('Get HTTP') |
|
|
||
| App::get('/v1/health/db') | ||
| ->desc('Get DB') | ||
| ->desc('Get db') |
There was a problem hiding this comment.
| ->desc('Get db') | |
| ->desc('Get DB') |
There was a problem hiding this comment.
6 participants
What does this PR do?
Convert descriptions from title case to sentence case
Test Plan
Manual inspection
Related PRs and Issues
Checklist