Style Appwrite Error Page - #5922
Merged
Merged
Conversation
eldadfux
requested changes
Aug 1, 2023
eldadfux
left a comment
eldadfux
left a comment
Member
There was a problem hiding this comment.
Let's use proper escape when printing stuff in the template.
Inside the template, we can use:
$this->print($value, View::FILTER_ESCAPE);https://github.com/utopia-php/framework/blob/master/src/View.php#L9C18-L9C31
https://github.com/utopia-php/framework/blob/master/src/View.php#L208
stnguyen90
force-pushed
the
feat-error-page
branch
from
August 1, 2023 18:23
464c69a to
ee6e65f
Compare
eldadfux
approved these changes
Aug 1, 2023
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If an endpoint throws an exception, an error like this is shown:
This PR adds some styling so that the page matches the Console
Test Plan
Manual:
Prod mode:
Dev mode:
Related PRs and Issues
None
Checklist