Separate OAuth2 info from Sessions into Identities - #5920
Closed
stnguyen90 wants to merge 5 commits into
Closed
stnguyen90 wants to merge 5 commits into
stnguyen90 wants to merge 5 commits into
Conversation
stnguyen90
changed the title
stnguyen90
force-pushed
the
feat-user-identities-1.4.x
branch
from
August 1, 2023 00:56
183d0d7 to
7b621e1
Compare
stnguyen90
marked this pull request as ready for review
August 1, 2023 01:28
This allows us to retain the OAuth2 info even if the session is deleted. This also provides a foundation for allowing multiple emails, phone numbers, etc, not from an OAuth2 provider.
Setting a password can cause problems with other APIs that expect the password to be null. In addition, it doesn't match the implementation for the other APIs that create a user without a password (Create Magic URL Session, Create Phone Session, Create Anonymous Session, etc).
Until we have a clearer picture of why we need it, it would be best to remove it since it's easier to add it later than to remove it after it's released.
stnguyen90
force-pushed
the
feat-user-identities-1.4.x
branch
from
August 2, 2023 22:37
7b621e1 to
b8e2215
Compare
This will allow developers to set up a job to find expired access tokens so they can refresh them.
2 tasks
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows us to retain the OAuth2 info even if the session is deleted. This also provides a foundation for allowing multiple emails, phone numbers, etc, not from an OAuth2 provider.
This PR was created to split out commits from #5551.
Test Plan
Manual
Related PRs and Issues
Checklist